amaliujia commented on a change in pull request #1761:
URL: https://github.com/apache/calcite/pull/1761#discussion_r411604525
##########
File path:
core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java
##########
@@ -2296,8 +2298,14 @@ public void unparse(
/** DESCRIPTOR(column_name, ...). */
public static final SqlOperator DESCRIPTOR = new SqlDescriptorOperator();
- /** TUMBLE as a table-value function. */
- public static final SqlFunction TUMBLE_TVF = new
SqlWindowTableFunction(SqlKind.TUMBLE.name());
+ /** TUMBLE as a table function. */
+ public static final SqlFunction TUMBLE_TVF = new SqlTumbleTableFunction();
+
+ /** HOP as a table function. */
+ public static final SqlFunction HOP_TVF = new SqlHopTableFunction();
+
+ /** SESSION as a table function. */
+ public static final SqlFunction SESSION_TVF = new SqlSessionTableFunction();
Review comment:
I am using e.g. "SESSION_TABLE_FUNCTION" right now.
Regarding old one to "_HOP" and use "HOP" for the new, how about put this
rename in a deprecation process? Directly renaming is not backward compatible.
I plan to send a discussion email to community to discuss the deprecation of
group window functions. We can decide how to rename it based on the discussion
(e.g. if people don't want to deprecate group window functions, it probably
means that they want keep `HOP` for hopping by group windowing function).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
