hsyuan commented on a change in pull request #1737:
URL: https://github.com/apache/calcite/pull/1737#discussion_r419689901
##########
File path: core/src/main/java/org/apache/calcite/interpreter/Bindables.java
##########
@@ -517,29 +521,76 @@ public Node implement(InterpreterImplementor implementor)
{
}
}
- /**
- * Rule to convert an {@link org.apache.calcite.rel.logical.LogicalUnion}
- * to a {@link BindableUnion}.
- */
- public static class BindableUnionRule extends ConverterRule {
+ @Deprecated // use BindableSetOpRule instead
+ public static class BindableUnionRule extends BindableSetOpRule {
/**
* Creates a BindableUnionRule.
*
* @param relBuilderFactory Builder for relational expressions
*/
public BindableUnionRule(RelBuilderFactory relBuilderFactory) {
- super(LogicalUnion.class, (Predicate<RelNode>) r -> true,
+ super(relBuilderFactory);
+ }
+ }
+
+ @Deprecated // use BindableSetOpRule instead
+ public static class BindableIntersectRule extends BindableSetOpRule {
+
+ /**
+ * Creates a BindableIntersectRule.
+ *
+ * @param relBuilderFactory Builder for relational expressions
+ */
+ public BindableIntersectRule(RelBuilderFactory relBuilderFactory) {
+ super(relBuilderFactory);
+ }
+ }
+
+ @Deprecated // use BindableSetOpRule instead
+ public static class BindableMinusRule extends BindableSetOpRule {
+
+ /**
+ * Creates a BindableMinusRule.
+ *
+ * @param relBuilderFactory Builder for relational expressions
+ */
+ public BindableMinusRule(RelBuilderFactory relBuilderFactory) {
+ super(relBuilderFactory);
+ }
+ }
Review comment:
There is no BindableIntersectRule, BindableMinusRule before, why do you
need this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
