This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git
commit 0aec07444f829104a0c2e1a5167d9200ba773dd4 Author: rubenada <[email protected]> AuthorDate: Wed Aug 5 12:02:48 2020 +0100 [CALCITE-4156] ReflectiveRelMetadataProvider constructor should throw an exception (instead of assertion) when called with an empty map --- .../apache/calcite/rel/metadata/ReflectiveRelMetadataProvider.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/core/src/main/java/org/apache/calcite/rel/metadata/ReflectiveRelMetadataProvider.java b/core/src/main/java/org/apache/calcite/rel/metadata/ReflectiveRelMetadataProvider.java index 6d3dea2..dd7ed49 100644 --- a/core/src/main/java/org/apache/calcite/rel/metadata/ReflectiveRelMetadataProvider.java +++ b/core/src/main/java/org/apache/calcite/rel/metadata/ReflectiveRelMetadataProvider.java @@ -25,6 +25,7 @@ import org.apache.calcite.util.Pair; import org.apache.calcite.util.ReflectiveVisitor; import org.apache.calcite.util.Util; +import com.google.common.base.Preconditions; import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableMultimap; import com.google.common.collect.Multimap; @@ -78,7 +79,8 @@ public class ReflectiveRelMetadataProvider ConcurrentMap<Class<RelNode>, UnboundMetadata> map, Class<? extends Metadata> metadataClass0, Multimap<Method, MetadataHandler> handlerMap) { - assert !map.isEmpty() : "are your methods named wrong?"; + Preconditions.checkArgument(!map.isEmpty(), "ReflectiveRelMetadataProvider " + + "methods map is empty; are your methods named wrong?"); this.map = map; this.metadataClass0 = metadataClass0; this.handlerMap = ImmutableMultimap.copyOf(handlerMap);
