amaliujia commented on a change in pull request #2103:
URL: https://github.com/apache/calcite/pull/2103#discussion_r468072910



##########
File path: 
core/src/main/java/org/apache/calcite/sql/fun/SqlArgumentAssignmentOperator.java
##########
@@ -47,4 +47,8 @@
     writer.keyword(getName());
     call.operand(0).unparse(writer, getRightPrec(), rightPrec);
   }
+
+  @Override public boolean argumentMustBeScalar(int ordinal) {
+    return false;

Review comment:
       This is really nice. I actually tried to add named parameter support but 
failed on make non-scalar work.
   
   I wasn't aware this can be as simple as override this parameter in 
SqlArgumentAssignmentOperator.java




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to