[GitHub] [calcite] liupc commented on a change in pull request #2164: [CALCITE-4176] Key descriptor can be optional in SESSION table function

[GitBox]

liupc commented on a change in pull request #2164:
URL: https://github.com/apache/calcite/pull/2164#discussion_r493997234



##########
File path: core/src/main/java/org/apache/calcite/sql/SqlHopTableFunction.java
##########
@@ -48,6 +48,9 @@ public SqlHopTableFunction() {
       if (!checkTableAndDescriptorOperands(callBinding, 1)) {
         return throwValidationSignatureErrorOrReturnFalse(callBinding, 
throwOnFailure);
       }
+      if (!checkTimeColumnDescriptorOperand(callBinding, 1)) {
+        return throwValidationSignatureErrorOrReturnFalse(callBinding, 
throwOnFailure);

Review comment:
       For TUMBLE/HOP table function, the descriptor must refer to a time 
column, I just add this check by the way. 
   currently, there is no tests to verify this change, but If it's ok to do it 
in this PR, I can add some tests for it.
   Or put it in another PR? what's your idea?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org