vlsi commented on a change in pull request #2255:
URL: https://github.com/apache/calcite/pull/2255#discussion_r521514988
##########
File path: core/src/main/java/org/apache/calcite/sql/SqlCallBinding.java
##########
@@ -201,7 +201,7 @@ private boolean hasAssignment() {
// with DEFAULT and then convert to nulls during sql-to-rel
conversion.
// Thus, there is no need to show the optional operands in the
plan and
// decide if the optional operand is null when code generation.
- permuted.add(DEFAULT_CALL);
+ permuted.add(createDefaultCall());
Review comment:
Should this be moved outside of the loop?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
