jamesstarr edited a comment on pull request #1901: URL: https://github.com/apache/calcite/pull/1901#issuecomment-796011229
Could we expand the revise call to take a RelMetadataProvider as an argument. Then create a static variable using an interface with the revise call in RelMetadataQueryBase. This would allow the removal of RelMetadataQueryBase.THREAD_PROVIDERS and allow customization by projects on how the dispatch is generated without forcing individual implementation into calcite main. Something like this https://github.com/apache/calcite/pull/2367. I am in the progress of migrating my company internal branch of Calcite to use the Janino backed metadata provider. However, there are several difficult to work around opinions in the current Janino Metadata Provider we do not share. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
