julianhyde commented on pull request #2435: URL: https://github.com/apache/calcite/pull/2435#issuecomment-859942767
I'd remove "Helper function that checks that", which is superfluous. Change the last parameter from `String expectedRelExpr` to `Matcher<String> planMatcher` and people will start using the function as an assert. Put the helper function before the class. We tend to put inner classes and interfaces last. Anyway. These are very pedantic points. It's a nice contribution; thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
