yinchuanwang commented on a change in pull request #2434: URL: https://github.com/apache/calcite/pull/2434#discussion_r671580495
########## File path: elasticsearch/src/test/java/org/apache/calcite/adapter/elasticsearch/SearchTest.java ########## @@ -0,0 +1,164 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.adapter.elasticsearch; Review comment: The main purpose of 'AggregationTest' is for aggregation tests which focus on the aggregation logic. With this PR, 2 search test cases (8 tests) are added. Maybe it is a little bit confusing to still leave them in 'AggregationTest' Another reason is the test data of 'Search' is a little bit different from 'Aggregation' for covering more scenarios of 'Search to Range'. In order to avoid to break the existing test cases of 'Aggregation', so I created a separate test class for Search. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
