zabetak commented on a change in pull request #2587:
URL: https://github.com/apache/calcite/pull/2587#discussion_r733497040



##########
File path: bom/build.gradle.kts
##########
@@ -147,7 +147,9 @@ dependencies {
         apiv("org.postgresql:postgresql")
         apiv("org.scala-lang:scala-library")
         apiv("org.slf4j:slf4j-api", "slf4j")
-        apiv("org.slf4j:slf4j-log4j12", "slf4j")
+        // Eventually we should get rid of slf4j-log4j12 dependency but 
currently it is not possible
+        // since certain modules (Pig, Piglet) have dependencies using 
directly Log4j 1.x APIs
+        runtimev("org.slf4j:slf4j-log4j12", "slf4j")

Review comment:
       I just created https://issues.apache.org/jira/browse/CALCITE-4862




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to