asolimando commented on a change in pull request #2592:
URL: https://github.com/apache/calcite/pull/2592#discussion_r735872549
##########
File path:
cassandra/src/test/java/org/apache/calcite/test/CassandraAdapterDataTypesTest.java
##########
@@ -131,7 +129,7 @@ static void load(Session session) {
+ "; f_inet=/192.168.0.1"
+ "; f_smallint=5"
+ "; f_text=abcdefg"
- + "; f_time=48654234000000"
+ + "; f_time=13:30:54.234"
Review comment:
The driver has changed the way this data type is handled internally and
it is not mapped to a `java.time.LocalTime`, which is what I think we should
return, as it matches exactly the input value:
https://github.com/apache/calcite/blob/87f60d2519dbb636d34687cbea5194ce0e8ef540/cassandra/src/test/resources/datatypes.cql#L80
However, this is breaking change and it should be discussed, and eventually
be addressed, in a separate JIRA ticket, I have handled the conversion to
nanoseconds to keep the same behaviour. I will file a ticket once this PR will
be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
