asolimando opened a new pull request #2613:
URL: https://github.com/apache/calcite/pull/2613


   ### Overview
   MV rewrite fails when at least one expression in the project of either the 
view or the query references, directly or indirectly, to more than one field.
   
   ### Changes
   - Added unit tests covering such "complex" expressions in both views and 
queries (highlighting the limitation)
   - Improved the implementation to handle such cases as well
   - Improved the error message for (possibly remaining) unhandled cases where 
a single expression can have multiple lineages, turned assertions into 
exceptions.
   
   Regarding the tests, the generated plans look fine, I was wondering if we 
could add tests with some actual data to double check that the rewriting is 
working as expected. So far I could not find the right place to add that, I 
will keep digging, not sure it's strictly needed, it does not seem to be done 
for any other case, no matter how complex.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to