mgramin commented on pull request #2646: URL: https://github.com/apache/calcite/pull/2646#issuecomment-1001489758
> General comment independent of this change: Do we really need `FilterCalcMergeRule` and `ProjectCalcMergeRule`? They look a bit redundant in the presence of `FilterToCalcRule` `ProjectToCalcRule` and `CalcMergeRule`. `FilterCalcMergeRule` and `ProjectCalcMergeRule` produce only `LogicalCalc` also, it can make further optimizations more difficult. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
