jacques-n commented on a change in pull request #2653:
URL: https://github.com/apache/calcite/pull/2653#discussion_r775619205



##########
File path: core/src/test/java/org/apache/calcite/test/RelMetadataTest.java
##########
@@ -3686,4 +4157,71 @@ Sql assertRowsUnique(boolean[] ignoreNulls, 
Matcher<Boolean> matcher,
     }
 
   }
+
+  /**
+   * A configuration that describes how metadata should be configured.
+   */
+  public static class MetadataConfig {
+
+    private final String name;
+    private final Function<RelMetadataProvider, MetadataHandlerProvider> 
converter;
+    private final Supplier<RelMetadataProvider> defaultProviderSupplier;
+    private final boolean isCaching;

Review comment:
       I've just added a test to verify no cycles in both impls. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to