rubenada commented on code in PR #2763:
URL: https://github.com/apache/calcite/pull/2763#discussion_r849220180
##########
core/src/test/java/org/apache/calcite/test/RelMetadataTest.java:
##########
@@ -644,6 +644,15 @@ final RelMetadataFixture sql(String sql) {
fixture.assertThatRowCount(is(9D), is(0D), is(10d));
}
+ @Test void testRowCountSortLimitOffsetDynamic() {
+ sql("select * from emp order by ename limit ? offset ?")
+ .assertThatRowCount(is(14D), is(0D), is(Double.POSITIVE_INFINITY));
Review Comment:
minor: in these tests, instead of `is(14D)`, I think it would be a bit
better to use `is(EMP_SIZE)` (as some other tests in the same class do).
Similarly, instead of `is(13D)` we could use `is(EMP_SIZE - 1)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
