zabetak commented on code in PR #2620:
URL: https://github.com/apache/calcite/pull/2620#discussion_r890062412
##########
core/src/main/java/org/apache/calcite/adapter/jdbc/JdbcRules.java:
##########
@@ -332,6 +332,9 @@ protected JdbcJoinRule(Config config) {
* @return Whether condition is supported
*/
private static boolean canJoinOnCondition(RexNode node) {
+ if (node.isAlwaysTrue() || node.isAlwaysFalse()) {
+ return true;
+ }
Review Comment:
`Join#isValid` ensures that the condition, in this case the literal, is
always a Boolean so there is no need for additional checks thus marking this
conversation as resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
