rubenada commented on code in PR #2838:
URL: https://github.com/apache/calcite/pull/2838#discussion_r904764600
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -6661,6 +6661,11 @@ static class ExtendedExpander extends Expander {
SqlIdentifier sid = (SqlIdentifier) expr;
final SqlIdentifier fqId = getScope().fullyQualify(sid).identifier;
expr = expandDynamicStar(sid, fqId);
+ } else {
+ requireNonNull(expr, "expr");
+ SqlNode exprCopy = expr.clone(expr.getParserPosition());
Review Comment:
I understand. Thanks for the explanation and for your patience.
LGTM. As I said, I'm not the most expert in SqlValidator (but there are not
many reviewers available at the moment, so I'll take responsibility for this
PR).
This patch fixes the bug without any regression, so I'll merge it in the
next 24h / 48h (if no objection appears).
@hannerwang could you please squash commits into a single one? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
