[GitHub] [calcite] dssysolyatin commented on a diff in pull request #2712: [CALCITE-4999] ARRAY, MULTISET functions should return a collection of scalars if a sub-query returns 1 column

[GitBox]

dssysolyatin commented on code in PR #2712:
URL: https://github.com/apache/calcite/pull/2712#discussion_r920992279


##########
core/src/main/java/org/apache/calcite/rel/core/Collect.java:
##########
@@ -132,6 +133,47 @@ public static Collect create(RelNode input,
             fieldName, input.getRowType()));
   }
 
+  /**
+   * Creates a Collect.
+   *
+   * @param input          Input relational expression
+   * @param sqlKind        SqlKind
+   * @param fieldName      Name of the sole output field
+   */
+  public static Collect create(RelNode input,

Review Comment:
   I think yes, `create(RelNode input,SqlTypeName collectionType, String 
fieldName)` should be deprecated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org