bchapuis opened a new pull request, #2879:
URL: https://github.com/apache/calcite/pull/2879

   Thanks a lot for calcite, it is truely awesome! As mentionned by @julianhyde 
in [#4294](https://issues.apache.org/jira/browse/CALCITE-4294), JTS now has a 
suitable license and may be used to replace the ESRI geometry api. 
   
   While experimenting with this change, I notices different behavirours 
between JTS and ESRI. For instance, the buffer operation in JTS returns a 
Polygon, whereas ESRI's implementation returns a MultiPolygon. When encoutering 
such cases, I adapted the tests to the new behaviour. However, project 
depending on these operations may encounter issues. Overall, I think the new 
behaviour is closer to what is done in Postgis. Should compatibility with the 
prior behaviour be preserved?
   
   Also, as JTS geometries have an SRID, I think some classes may be removed or 
simplified (e.g. SpatialReference, Geom, SimpleGeom, MapGeom). Since 
[#4294](https://issues.apache.org/jira/browse/CALCITE-4294) was created in 2020 
and is mostly inactive, I just want to check that this issue is still relevant 
before going further ;)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to