libenchao commented on code in PR #2883:
URL: https://github.com/apache/calcite/pull/2883#discussion_r956529675
##########
core/src/main/java/org/apache/calcite/sql/dialect/BigQuerySqlDialect.java:
##########
@@ -183,6 +183,15 @@ public BigQuerySqlDialect(SqlDialect.Context context) {
case TRIM:
unparseTrim(writer, call, leftPrec, rightPrec);
break;
+ case ITEM:
Review Comment:
`ITEM` is not only used for `array`, but also for `map`, `struct`. So it's
better to check whether the `operand(0)` is an `array`.
Besides, does `ORDINAL` only work in the array accessing in BigQuery? Are
there any other places that also need to be handled like this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
