pjfanning commented on code in PR #2892:
URL: https://github.com/apache/calcite/pull/2892#discussion_r965221384
##########
core/src/main/java/org/apache/calcite/runtime/XmlFunctions.java:
##########
@@ -60,13 +67,41 @@
public class XmlFunctions {
private static final ThreadLocal<@Nullable XPathFactory> XPATH_FACTORY =
- ThreadLocal.withInitial(XPathFactory::newInstance);
+ ThreadLocal.withInitial(() -> {
+ final XPathFactory xPathFactory = XPathFactory.newInstance();
+ try {
+ xPathFactory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING,
true);
+ } catch (XPathFactoryConfigurationException e) {
+ throw new IllegalStateException("XPath Factory configuration
failed", e);
+ }
+ return xPathFactory;
+ });
private static final ThreadLocal<@Nullable TransformerFactory>
TRANSFORMER_FACTORY =
ThreadLocal.withInitial(() -> {
- TransformerFactory transformerFactory =
TransformerFactory.newInstance();
+ final TransformerFactory transformerFactory =
TransformerFactory.newInstance();
transformerFactory.setErrorListener(new InternalErrorListener());
+ try {
+
transformerFactory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true);
+ } catch (TransformerConfigurationException e) {
+ throw new IllegalStateException("Transformer Factory configuration
failed", e);
+ }
return transformerFactory;
});
+ private static final ThreadLocal<@Nullable DocumentBuilderFactory>
DOCUMENT_BUILDER_FACTORY =
Review Comment:
I raised https://issues.apache.org/jira/browse/CALCITE-5274 just in case -
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
