thomasrebele commented on PR #2899: URL: https://github.com/apache/calcite/pull/2899#issuecomment-1240661122
Seems that we have different definitions of simple code ;) I have the impression that an `IdentityHashMap` and an `ArrayList` is a bit easier to understand than a `LinkedHashMap` with a `Equivalence.Wrapper<Object>`. A comment at `stashedParameters` could indicate to update the list as well. A check whether the map and the list have the same number of elements could be added. However, this is only a minor detail. If you insist on using the Equivalence class, the PR is fine for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
