This is an automated email from the ASF dual-hosted git repository. libenchao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push: new 4805478594 [CALCITE-5267] Remove unused variable 'newCasts' in AggregateCaseToFilterRule 4805478594 is described below commit 48054785949eedb6c8836a5114cdc8c72aaf3ee4 Author: wenzhuang.zwz <wenzhuang....@alibaba-inc.com> AuthorDate: Tue Sep 6 16:10:13 2022 +0800 [CALCITE-5267] Remove unused variable 'newCasts' in AggregateCaseToFilterRule We now use RelBuilder#convert to make casts. This closes #2895 --- .../calcite/rel/rules/AggregateCaseToFilterRule.java | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/core/src/main/java/org/apache/calcite/rel/rules/AggregateCaseToFilterRule.java b/core/src/main/java/org/apache/calcite/rel/rules/AggregateCaseToFilterRule.java index e11e8c512f..d2056894c0 100644 --- a/core/src/main/java/org/apache/calcite/rel/rules/AggregateCaseToFilterRule.java +++ b/core/src/main/java/org/apache/calcite/rel/rules/AggregateCaseToFilterRule.java @@ -101,34 +101,18 @@ public class AggregateCaseToFilterRule @Override public void onMatch(RelOptRuleCall call) { final Aggregate aggregate = call.rel(0); final Project project = call.rel(1); - final RexBuilder rexBuilder = aggregate.getCluster().getRexBuilder(); final List<AggregateCall> newCalls = new ArrayList<>(aggregate.getAggCallList().size()); final List<RexNode> newProjects = new ArrayList<>(project.getProjects()); - final List<RexNode> newCasts = new ArrayList<>(); - - for (int fieldNumber : aggregate.getGroupSet()) { - newCasts.add( - rexBuilder.makeInputRef( - project.getProjects().get(fieldNumber).getType(), fieldNumber)); - } for (AggregateCall aggregateCall : aggregate.getAggCallList()) { AggregateCall newCall = transform(aggregateCall, project, newProjects); - // Possibly CAST the new aggregator to an appropriate type. - final int i = newCasts.size(); - final RelDataType oldType = - aggregate.getRowType().getFieldList().get(i).getType(); if (newCall == null) { newCalls.add(aggregateCall); - newCasts.add(rexBuilder.makeInputRef(oldType, i)); } else { newCalls.add(newCall); - newCasts.add( - rexBuilder.makeCast(oldType, - rexBuilder.makeInputRef(newCall.getType(), i))); } }