[GitHub] [calcite] zabetak commented on a diff in pull request #2915: [CALCITE-5293] Support general set operators in PruneEmptyRules

[GitBox]

zabetak commented on code in PR #2915:
URL: https://github.com/apache/calcite/pull/2915#discussion_r976486206


##########
core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java:
##########
@@ -94,7 +94,7 @@ public interface Config extends RelRule.Config {
   public static final RelOptRule UNION_INSTANCE =
       ImmutableUnionEmptyPruneRuleConfig.of()
           .withOperandSupplier(b0 ->
-              b0.operand(LogicalUnion.class).unorderedInputs(b1 ->
+              b0.operand(Union.class).unorderedInputs(b1 ->

Review Comment:
   Better leave the default configurations unchanged to avoid accidentally 
breaking other projects. Projects who wish to enlarge the matching scope can 
modify the configuration.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org