[GitHub] [calcite] l4wei commented on a diff in pull request #2910: [CALCITE-5265] Select operator' parentheses should be same with Union operator

[GitBox]

l4wei commented on code in PR #2910:
URL: https://github.com/apache/calcite/pull/2910#discussion_r981260935


##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -6352,6 +6352,20 @@ private void checkLiteral2(String expression, String 
expected) {
         .withCalcite().ok(expectedCalciteX);
   }
 
+  /** Test case for
+   * <a 
href="https://issues.apache.org/jira/browse/CALCITE-5265";>[CALCITE-5265]
+   * Select operator' parentheses should be same with Union operator</a>. */
+  @Test void testInsertValueWithDynamicParams() {

Review Comment:
   There are many unit tests cover "insert into aTable select ? from bTable" in 
SqlParserTest.java. And 
RelToSqlConverterTest::testInsertValuesWithDynamicParams will cover "insert 
into aTable select ? from bTable union all select ? from cTable" mentioned by 
Julian in JIRA comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org