zabetak commented on code in PR #2813:
URL: https://github.com/apache/calcite/pull/2813#discussion_r984488709
##########
core/src/main/java/org/apache/calcite/rel/core/Project.java:
##########
@@ -137,20 +163,27 @@ protected Project(RelInput input) {
* @param input Input
* @param projects Project expressions
* @param rowType Output row type
+ * @param variableSet The variable set.
* @return New {@code Project} if any parameter differs from the value of
this
* {@code Project}, or just {@code this} if all the parameters are
* the same
*
* @see #copy(RelTraitSet, List)
*/
public abstract Project copy(RelTraitSet traitSet, RelNode input,
- List<RexNode> projects, RelDataType rowType);
+ List<RexNode> projects, RelDataType rowType, Set<CorrelationId>
variableSet);
+
+ @Deprecated // to be removed before 2.0
+ public Project copy(RelTraitSet traitSet, RelNode input,
+ List<RexNode> projects, RelDataType rowType) {
+ return copy(traitSet, input, projects, rowType, ImmutableSet.of());
+ }
Review Comment:
The question is if it is used in a meaningful way? As far as I can see we
are always passing the same `variableSet`. If we don't need to change the
`variableSet` as part of the copy then we don't need the new method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
