[GitHub] [calcite] wojustme commented on a diff in pull request #2920: [CALCITE-5296] In a query with ROLLUP, validator wrongly infers that a column is NOT NULL

Sat, 08 Oct 2022 05:11:34 -0700 


wojustme commented on code in PR #2920:
URL: https://github.com/apache/calcite/pull/2920#discussion_r990634393


##########
core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java:
##########
@@ -4688,4 +4688,5 @@ void checkCorrelatedMapSubQuery(boolean expand) {
     String sql = "SELECT CAST(CAST(? AS INTEGER) AS CHAR)";
     sql(sql).ok();
   }
+

Review Comment:
   @libenchao 
   Thank you for reminding me.
   And PR is updated, please review again.
   Ping me to rebase it, if it's ok.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to