l4wei commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r996591355
########## core/src/main/java/org/apache/calcite/sql/pretty/SqlPrettyWriter.java: ########## @@ -398,10 +398,14 @@ public void setWindowDeclListNewline(boolean windowDeclListNewline) { return (frame == null) || (frame.frameType == FrameTypeEnum.SELECT) || (frame.frameType == FrameTypeEnum.ORDER_BY) - || (frame.frameType == FrameTypeEnum.WITH) + || (frame.frameType == FrameTypeEnum.WITH_BODY) Review Comment: SqlWriter#inQuery 's java doc says: "whether we are currently in a query context", not "whether we are currently in a sub-query context", so I think current java doc is appropriate? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org