dssysolyatin commented on code in PR #2929:
URL: https://github.com/apache/calcite/pull/2929#discussion_r1020099005


##########
core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java:
##########
@@ -1790,10 +1790,11 @@ private RexNode createCaseExpression(
 
     @Override public RexNode visitLiteral(RexLiteral literal) {
       // Use nullIndicator to decide whether to project null.
-      // Do nothing if the literal is null.
+      // Do nothing if the literal is null or symbol.
       if (!RexUtil.isNull(literal)

Review Comment:
   Do I understand correctly that if I have query like:
   ```
   SELECT (SELECT CARDINALITY(ARRAY[false, true, a.attidentity = 'a']) FROM 
UNNEST(ARRAY[1]) as v) as options
   FROM UNNEST(ARRAY['a', 'b']) AS a(attidentity);
   ```
   RelDecorrelator will try to wrap true and false into case expression ?
   
   Another question. why do we need to wrap literals into case expression at 
all ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to