[GitHub] [calcite] rubenada commented on a diff in pull request #2977: [CALCITE-5388] No result when using ROW_NUMBER in two common table expressions

[GitBox]

rubenada commented on code in PR #2977:
URL: https://github.com/apache/calcite/pull/2977#discussion_r1038240351


##########
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableWindow.java:
##########
@@ -693,7 +696,7 @@ private static Pair<Expression, Expression> 
getPartitionIterator(
     }
     Expression multiMap_ =
         builder.append(
-            "multiMap", Expressions.new_(SortedMultiMap.class));
+            "multiMap", Expressions.new_(SortedMultiMap.class), false);

Review Comment:
   @dssysolyatin thanks for the clarification. Sorry if I insist, but in the 
Jira you talk about a scenario that returns empty result instead of the 
expected rows; wouldn't it be possible to reproduce that in a unit test?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org