[GitHub] [calcite] dssysolyatin commented on a diff in pull request #2977: [CALCITE-5388] No result when using ROW_NUMBER in two common table expressions

[GitBox]

dssysolyatin commented on code in PR #2977:
URL: https://github.com/apache/calcite/pull/2977#discussion_r1038245590


##########
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableWindow.java:
##########
@@ -693,7 +696,7 @@ private static Pair<Expression, Expression> 
getPartitionIterator(
     }
     Expression multiMap_ =
         builder.append(
-            "multiMap", Expressions.new_(SortedMultiMap.class));
+            "multiMap", Expressions.new_(SortedMultiMap.class), false);

Review Comment:
   @rubenada For case when tempList is used, the query returns empty result 
without this fix. 
   The following test case covers it:
   ```
   with
       CTE1(rownr1, val1) as ( select ROW_NUMBER() OVER(ORDER BY id ASC), id 
from (values (1), (2)) as Vals1(id) ),
       CTE2(rownr2, val2) as ( select ROW_NUMBER() OVER(ORDER BY id ASC), id 
from (values (1), (2)) as Vals2(id) )
   select
       CTE1.rownr1, CTE1.val1, CTE2.rownr2, CTE2.val2
   from
       CTE1,CTE2
   where
       CTE1.val1 = CTE2.val2;
   
   +--------+------+--------+------+
   | ROWNR1 | VAL1 | ROWNR2 | VAL2 |
   +--------+------+--------+------+
   |      1 |    1 |      1 |    1 |
   |      2 |    2 |      2 |    2 |
   +--------+------+--------+------+
   (2 rows)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org