freastro commented on code in PR #197: URL: https://github.com/apache/calcite-avatica/pull/197#discussion_r1042559515
########## core/src/test/java/org/apache/calcite/avatica/util/TimestampFromUtilDateAccessorTest.java: ########## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.avatica.util; + +import org.junit.Before; +import org.junit.Test; + +import java.sql.SQLException; +import java.sql.Time; +import java.sql.Timestamp; +import java.util.Calendar; +import java.util.Date; +import java.util.Locale; +import java.util.SimpleTimeZone; +import java.util.TimeZone; + +import static org.apache.calcite.avatica.util.DateTimeUtils.MILLIS_PER_HOUR; + +import static org.hamcrest.CoreMatchers.is; +import static org.hamcrest.MatcherAssert.assertThat; + +public class TimestampFromUtilDateAccessorTest { Review Comment: Thanks for the suggestion. I've added a javadoc comment to every method and class. ########## core/src/test/java/org/apache/calcite/avatica/util/TimestampFromUtilDateAccessorTest.java: ########## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.avatica.util; + +import org.junit.Before; +import org.junit.Test; + +import java.sql.SQLException; +import java.sql.Time; +import java.sql.Timestamp; +import java.util.Calendar; +import java.util.Date; +import java.util.Locale; +import java.util.SimpleTimeZone; +import java.util.TimeZone; + +import static org.apache.calcite.avatica.util.DateTimeUtils.MILLIS_PER_HOUR; + +import static org.hamcrest.CoreMatchers.is; +import static org.hamcrest.MatcherAssert.assertThat; + +public class TimestampFromUtilDateAccessorTest { + + private static final Calendar UTC = + Calendar.getInstance(TimeZone.getTimeZone("UTC"), Locale.ROOT); + + private Cursor.Accessor instance; + private Calendar localCalendar; + private Date value; + + @Before + public void before() { + final AbstractCursor.Getter getter = new LocalGetter(); + localCalendar = Calendar.getInstance(TimeZone.getDefault(), Locale.ROOT); + instance = new AbstractCursor.TimestampFromUtilDateAccessor(getter, localCalendar); + } + + @Test + public void testTimestamp() throws SQLException { + value = new Timestamp(0L); Review Comment: I've updated every test as requested, except for removing `public` which seems to break the tests. ########## core/src/test/java/org/apache/calcite/avatica/util/DateAccessorTest.java: ########## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.avatica.util; + +import org.junit.Before; +import org.junit.Test; + +import java.sql.Date; +import java.sql.SQLException; +import java.util.Calendar; +import java.util.Locale; +import java.util.TimeZone; + +import static org.hamcrest.CoreMatchers.is; +import static org.hamcrest.MatcherAssert.assertThat; + +public class DateAccessorTest { + + private static final Calendar UTC = + Calendar.getInstance(TimeZone.getTimeZone("UTC"), Locale.ROOT); + + private Cursor.Accessor instance; + private Calendar localCalendar; + private Date value; Review Comment: Thanks for the suggestion. I like to push common test code to the `@Before` method. I think it makes the tests more readable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
