julianhyde commented on code in PR #3002:
URL: https://github.com/apache/calcite/pull/3002#discussion_r1049151469
##########
core/src/main/java/org/apache/calcite/runtime/CalciteResource.java:
##########
@@ -66,6 +66,9 @@ public interface CalciteResource {
@BaseMessage("Geo-spatial extensions and the GEOMETRY data type are not
enabled")
ExInst<SqlValidatorException> geometryDisabled();
+ @BaseMessage("Proj4J EPSG is missing from the classpath")
+ ExInst<CalciteException> proj4jEpsgIsMissing();
Review Comment:
I would add '; to resolve this problem, download the EPSG data set and agree
to its terms of use'
##########
bom/build.gradle.kts:
##########
@@ -58,6 +58,7 @@ dependencies {
apiv("org.locationtech.jts:jts-core")
apiv("org.locationtech.jts.io:jts-io-common")
apiv("org.locationtech.proj4j:proj4j")
+ apiv("org.locationtech.proj4j:proj4j-epsg")
Review Comment:
If proj4j and proj4j-epsg are likely to have the same version number there's
no need for this line, or the line in gradle.properties.
##########
core/build.gradle.kts:
##########
@@ -98,6 +98,7 @@ dependencies {
testImplementation(kotlin("stdlib-jdk8"))
testImplementation(kotlin("test"))
testImplementation(kotlin("test-junit5"))
+ testRuntimeOnly("org.locationtech.proj4j:proj4j-epsg")
Review Comment:
add a comment that proj4j-epsg must not be converted 'implementation' due to
its license
##########
site/_docs/reference.md:
##########
@@ -2438,6 +2438,9 @@ Not implemented:
#### Geometry projection functions
+The EPSG dataset is released separately from Proj4J due to its restrictive
[terms of use](https://epsg.org/terms-of-use.html).
+In order to use the projection functions in Apache Calcite, users must include
the EPSG dataset in their dependencies.
Review Comment:
Can you shorten the lines? In my opinion there's little reason not to wrap
text at 60 or 70 characters. Long lines are difficult to view in diff output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
