tanclary commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1073952163
########## core/src/main/java/org/apache/calcite/sql/dialect/MysqlSqlDialect.java: ########## @@ -184,6 +185,46 @@ public MysqlSqlDialect(Context context) { return super.getCastSpec(type); } + /** {@inheritDoc} + * + * <p>MySQL format element reference: + * <a href="https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_date-format"> + * MySQL Date and Time Functions</a>. + */ + @Override public String getFormatElement(FormatElementEnum fmtElement) { Review Comment: Makes sense! Looks great. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org