chunweilei commented on code in PR #3057:
URL: https://github.com/apache/calcite/pull/3057#discussion_r1105246098
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -759,17 +760,17 @@ private static String toSql(RelNode root, SqlDialect
dialect,
final String expected = "SELECT \"product_class_id\", COUNT(*) AS \"C\"\n"
+ "FROM \"foodmart\".\"product\"\n"
+ "GROUP BY ROLLUP(\"product_class_id\")\n"
- + "ORDER BY \"product_class_id\", COUNT(*)";
+ + "ORDER BY \"product_class_id\", 2";
final String expectedMysql = "SELECT `product_class_id`, COUNT(*) AS `C`\n"
+ "FROM `foodmart`.`product`\n"
Review Comment:
COUNT(*) is replaced by 2 rather than 1. So the ordinal starts from 1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
