wnob commented on code in PR #207:
URL: https://github.com/apache/calcite-avatica/pull/207#discussion_r1106348967
##########
core/src/test/java/org/apache/calcite/avatica/util/TimeAccessorTest.java:
##########
@@ -46,12 +49,13 @@ public class TimeAccessorTest {
*/
@Before public void before() {
final AbstractCursor.Getter getter = new LocalGetter();
- localCalendar = Calendar.getInstance(TimeZone.getDefault(), Locale.ROOT);
- instance = new AbstractCursor.TimeAccessor(getter, localCalendar);
+ localCalendar = Calendar.getInstance(IST_ZONE, Locale.ROOT);
Review Comment:
The local time zone is injected at a higher level than inside the getters.
The getters are provided with the local time zone at construction time by
`AbstractCursor`, so the logic involving the system default time zone is tested
in `AvaticaResultSetConversionsTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
