olivrlee commented on code in PR #3084:
URL: https://github.com/apache/calcite/pull/3084#discussion_r1120685121
##########
core/src/main/java/org/apache/calcite/jdbc/Driver.java:
##########
@@ -64,6 +64,15 @@ public Driver() {
this.prepareFactory = createPrepareFactory();
}
+ private Driver(Function0<CalcitePrepare> prepareFactory) {
Review Comment:
I've unified the constructors in my last commit:
https://github.com/apache/calcite/pull/3084/commits/5314d5d29e5cd6d271626d7b877125278e8292d4#diff-202586edbf28484a3a4c1498d8f61096e7a12c0a9c813260fb4282b5c19a3e96R63
But it doesn't compile due to no explicit assigning of prepareFactory.
Do you have suggestions here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]