julianhyde commented on code in PR #3128:
URL: https://github.com/apache/calcite/pull/3128#discussion_r1147929441
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibrary.java:
##########
@@ -94,11 +97,21 @@ public enum SqlLibrary {
/** Parses a comma-separated string such as "standard,oracle". */
public static List<SqlLibrary> parse(String libraryNameList) {
final ImmutableList.Builder<SqlLibrary> list = ImmutableList.builder();
- for (String libraryName : libraryNameList.split(",")) {
- SqlLibrary library =
- requireNonNull(SqlLibrary.of(libraryName),
- () -> "library does not exist: " + libraryName);
- list.add(library);
+ List<String> libList = Arrays.asList(libraryNameList.split(","));
Review Comment:
Does this do the right thing if someone writes 'all,spatial'? I suspect not,
but even if it does, it's not clear.
To simplify, change the method contract so that it may contain duplicates,
may contain 'all', and may not be sorted. Then deal with expanding 'all' in the
code that calls the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
