MasseGuillaume commented on code in PR #3161:
URL: https://github.com/apache/calcite/pull/3161#discussion_r1170399078
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -3490,6 +3491,12 @@ private static AtomicLong getAtomicLong(String key) {
return atomic;
}
+ /** Support the ARRAY_DISTINCT function. */
+ public static List distinct(List list) {
+ Set result = new LinkedHashSet<>(list);
Review Comment:
I'm not super familiar with SQL distinct semantics, but this might be not
enough:
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/util/SQLOpenHashSet.scala#L27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
