cgivre commented on code in PR #3174:
URL: https://github.com/apache/calcite/pull/3174#discussion_r1177173476
##########
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchSchemaFactory.java:
##########
@@ -151,18 +188,20 @@ public ElasticsearchSchemaFactory() {
* @param password the password of ES
* @return new or cached low-level rest http client for ES
*/
+ @SuppressWarnings({"java:S4830", "java:S5527"})
private static RestClient connect(List<HttpHost> hosts, String pathPrefix,
- String username, String password) {
+ String username, String password,
+ boolean disableSSLVerification) {
Objects.requireNonNull(hosts, "hosts or coordinates");
Preconditions.checkArgument(!hosts.isEmpty(), "no ES hosts specified");
// Two lists are considered equal when all of their corresponding elements
are equal
- // making a list of RestClient parms a suitable cache key.
+ // making a list of RestClient params a suitable cache key.
Review Comment:
:-p
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
