libenchao commented on code in PR #3191:
URL: https://github.com/apache/calcite/pull/3191#discussion_r1189744018
##########
core/src/test/java/org/apache/calcite/test/JdbcAdapterTest.java:
##########
@@ -135,6 +135,14 @@ class JdbcAdapterTest {
+ "WHERE \"product_id\" = 1");
}
+ @Test void testFilterUnionIncludingWithPlan() {
Review Comment:
Unfortunately `JdbcAdapterTest` is not the best place for this testing
purpose, as I said above, I prefer to add tests in `SqlValidatorTest` instead
of `JdbcAdapterTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
