herunkang2018 commented on code in PR #3267:
URL: https://github.com/apache/calcite/pull/3267#discussion_r1231086325
##########
core/src/test/java/org/apache/calcite/rex/RexProgramTest.java:
##########
@@ -1604,6 +1604,48 @@ private void checkExponentialCnf(int n) {
"true");
}
+ /** Unit test for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-5780";>[CALCITE-5780]
+ * Always-true OR expressions contain reverse order comparison
+ * should be simplified to TRUE</a>. */
+ @Test void testSimplifyOrTermsWithReverseOrderComparison() {
+ final RelDataType intType = typeFactory.createSqlType(SqlTypeName.INTEGER);
+ final RelDataType rowType = typeFactory.builder()
Review Comment:
@NobiGo IMO, `a is not null` is not releated to the issue we want to solve
here, unlike `a is null`, `1 < a or 1 >= a or a is not null` will return
UNKNOWN when a's type is nullable and a's value is null, return TRUE when
a'type is not nullable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
