libenchao commented on PR #3193: URL: https://github.com/apache/calcite/pull/3193#issuecomment-1596028987
@HanumathRao Thanks for letting me know. I've gone through the PR again, I find that the `if (filter.getVariablesSet().size() > 0)` has been reverted, so I added it back, and added a test for it. After that, it seems that the last test in `sub-query.iq` is broken. The changes I made is in https://github.com/libenchao/calcite/commits/5683-nested-correlated-sub-query-throws-2, it also contains some fixups for coding style. It seems that there is still something that does not work well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
