[GitHub] [calcite] libenchao commented on a diff in pull request #3277: [CALCITE-5789] Query with two nested subqueries where the inner-most references the outer-most table returns wrong result

Mon, 26 Jun 2023 08:20:25 -0700 


libenchao commented on code in PR #3277:
URL: https://github.com/apache/calcite/pull/3277#discussion_r1242366055


##########
core/src/main/java/org/apache/calcite/rel/rules/SubQueryRemoveRule.java:
##########
@@ -865,6 +866,9 @@ private static void matchFilter(SubQueryRemoveRule rule,
           LogicVisitor.find(RelOptUtil.Logic.TRUE, ImmutableList.of(c), e);
       final Set<CorrelationId>  variablesSet =
           RelOptUtil.getVariablesUsed(e.rel);
+      if (!filterVariablesSet.isEmpty()) {
+        variablesSet.retainAll(filterVariablesSet);

Review Comment:
   I agree and would give a big thanks to you for doing it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to