julianhyde commented on PR #3234:
URL: https://github.com/apache/calcite/pull/3234#issuecomment-1624488746

   If I were to make `safeDouble` always return true, would any tests fail?
   
   If I wrote
   ```
   boolean safeBoolean(boolean b) {
     return b == true || b == false;
   }
   ```
   it's obvious that it will always return true. But I don't see how 
`safeDouble` is any different, because you've already dealt with inf and -inf. 
Maybe you just need to check for NaN. `java.lang.Double` has methods for that 
kind of thing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to