[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #3289: [CALCITE-5813] Improve type inference for REPEAT, SPACE, XML_TRANSFORM, and XML_EXTRACT functions

[via GitHub]

JiajunBernoulli commented on code in PR #3289:
URL: https://github.com/apache/calcite/pull/3289#discussion_r1256811929


##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -5122,7 +5122,115 @@ private static void checkIf(SqlOperatorFixture f) {
         + "</xsl:stylesheet>')";
     f.checkString(sql2,
         "    Article - My Article    Authors:     - Mr. Foo    - Mr. Bar",
-        "VARCHAR(2000)");
+        "VARCHAR");
+
+    // Reproduction for [CALCITE-5813]
+    final String sql3 = "XMLTRANSFORM("
+        + "'<?xml version=\"1.0\"?>\n"
+        + "<Article>\n"
+        + "  <Title>My Article</Title>\n"
+        + "  <Authors>\n"
+        + "    <Author>Mr. Foo</Author>\n"
+        + "    <Author>Mr. Bar</Author>\n"
+        + "    <Author>Mr. Bar                                                 
       0</Author>\n"

Review Comment:
   Can we use `for index` to build it?
   `<Author>Mr. Bar 1</Author>\n...`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org