chunweilei commented on code in PR #3288:
URL: https://github.com/apache/calcite/pull/3288#discussion_r1257659204
##########
core/src/main/java/org/apache/calcite/rel/rules/SemiJoinRule.java:
##########
@@ -67,13 +67,12 @@ protected SemiJoinRule(Config config) {
super(config);
}
- protected void perform(RelOptRuleCall call, @Nullable Project project,
+ protected void perform(RelOptRuleCall call, @Nullable RelNode topRel,
Join join, RelNode left, Aggregate aggregate) {
final RelOptCluster cluster = join.getCluster();
final RexBuilder rexBuilder = cluster.getRexBuilder();
- if (project != null) {
- final ImmutableBitSet bits =
- RelOptUtil.InputFinder.bits(project.getProjects(), null);
+ if (topRel != null) {
+ final ImmutableBitSet bits = findBits(topRel);
Review Comment:
It should return directly If `findBits` returns empty BitSet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
