tanclary commented on code in PR #3378:
URL: https://github.com/apache/calcite/pull/3378#discussion_r1300362501
##########
babel/src/test/resources/sql/big-query.iq:
##########
@@ -668,6 +668,77 @@ SELECT SAFE_ADD(CAST('NaN' AS DOUBLE), CAST(3 as BIGINT))
as NaN_result;
(1 row)
!ok
+
+#####################################################################
+# SAFE_DIVIDE
Review Comment:
Yeah I figured there implementations were similar enough that it might be a
bit tedious for reviewers to review two very similar PRs, but I'm happy to
split it up if it's easier. What do you think?
##########
babel/src/test/resources/sql/big-query.iq:
##########
@@ -668,6 +668,77 @@ SELECT SAFE_ADD(CAST('NaN' AS DOUBLE), CAST(3 as BIGINT))
as NaN_result;
(1 row)
!ok
+
+#####################################################################
+# SAFE_DIVIDE
Review Comment:
Yeah I figured their implementations were similar enough that it might be a
bit tedious for reviewers to review two very similar PRs, but I'm happy to
split it up if it's easier. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
