tanclary commented on code in PR #3395:
URL: https://github.com/apache/calcite/pull/3395#discussion_r1333269098
##########
babel/src/test/resources/sql/big-query.iq:
##########
@@ -1012,9 +1012,9 @@ FROM
SELECT
Review Comment:
Nit: could we change the commit message to "Use explicit casting if element
type in ARRAY/MAP does not equal derived component type"
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java:
##########
@@ -1309,6 +1311,63 @@ public static boolean isMeasure(SqlNode selectItem) {
return null;
}
+ /**
+ * When the array element does not equal the array component type, make
explicit casting.
+ *
+ * @param componentType derived array component type
+ * @param opBinding description of call
+ */
+ public static void adjustTypeForArrayConstructor(
+ RelDataType componentType, SqlOperatorBinding opBinding) {
+ if (opBinding instanceof SqlCallBinding) {
+ requireNonNull(componentType, "array component type");
+ adjustTypeForMultisetConstructor(
+ componentType, componentType, (SqlCallBinding) opBinding);
+ }
+ }
+
+ /**
+ * When the map key or value does not equal the map component key type or
value type,
+ * make explicit casting.
+ *
+ * @param componentType derived map pair component type
+ * @param opBinding description of call
+ */
+ public static void adjustTypeForMapConstructor(
+ Pair<RelDataType, RelDataType> componentType, SqlOperatorBinding
opBinding) {
+ if (opBinding instanceof SqlCallBinding) {
+ requireNonNull(componentType.getKey(), "map key type");
+ requireNonNull(componentType.getValue(), "map value type");
+ adjustTypeForMultisetConstructor(
+ componentType.getKey(), componentType.getValue(), (SqlCallBinding)
opBinding);
+ }
+ }
+
+ private static void adjustTypeForMultisetConstructor(
+ RelDataType evenType, RelDataType oddType, SqlCallBinding
sqlCallBinding) {
+ SqlCall call = sqlCallBinding.getCall();
+ List<RelDataType> operandTypes = sqlCallBinding.collectOperandTypes();
+ List<SqlNode> operands = call.getOperandList();
+ RelDataType elementType;
+ for (int i = 0; i < operands.size(); i++) {
+ if (i % 2 == 0) {
+ elementType = evenType;
Review Comment:
could you explain `even` and `odd` types? I am not sure what that means
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java:
##########
@@ -1309,6 +1311,63 @@ public static boolean isMeasure(SqlNode selectItem) {
return null;
}
+ /**
+ * When the array element does not equal the array component type, make
explicit casting.
+ *
+ * @param componentType derived array component type
+ * @param opBinding description of call
+ */
+ public static void adjustTypeForArrayConstructor(
+ RelDataType componentType, SqlOperatorBinding opBinding) {
+ if (opBinding instanceof SqlCallBinding) {
+ requireNonNull(componentType, "array component type");
+ adjustTypeForMultisetConstructor(
+ componentType, componentType, (SqlCallBinding) opBinding);
+ }
+ }
+
+ /**
+ * When the map key or value does not equal the map component key type or
value type,
+ * make explicit casting.
+ *
+ * @param componentType derived map pair component type
+ * @param opBinding description of call
+ */
+ public static void adjustTypeForMapConstructor(
+ Pair<RelDataType, RelDataType> componentType, SqlOperatorBinding
opBinding) {
+ if (opBinding instanceof SqlCallBinding) {
+ requireNonNull(componentType.getKey(), "map key type");
+ requireNonNull(componentType.getValue(), "map value type");
+ adjustTypeForMultisetConstructor(
+ componentType.getKey(), componentType.getValue(), (SqlCallBinding)
opBinding);
+ }
+ }
+
+ private static void adjustTypeForMultisetConstructor(
+ RelDataType evenType, RelDataType oddType, SqlCallBinding
sqlCallBinding) {
+ SqlCall call = sqlCallBinding.getCall();
+ List<RelDataType> operandTypes = sqlCallBinding.collectOperandTypes();
+ List<SqlNode> operands = call.getOperandList();
+ RelDataType elementType;
+ for (int i = 0; i < operands.size(); i++) {
+ if (i % 2 == 0) {
+ elementType = evenType;
+ } else {
+ elementType = oddType;
+ }
+ if (!operandTypes.get(i).equalsSansFieldNames(elementType)) {
+ call.setOperand(i, castTo(operands.get(i), elementType));
+ }
+ }
+ }
+
+ private static SqlNode castTo(SqlNode node, RelDataType type) {
Review Comment:
Can we javadoc these private methods? It seems that a lot of the actual
logic lives within them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
