WegdanGhazi commented on code in PR #3436:
URL: https://github.com/apache/calcite/pull/3436#discussion_r1335489532


##########
core/src/test/java/org/apache/calcite/test/JdbcTest.java:
##########
@@ -8247,6 +8343,33 @@ private static String sums(int n, boolean c) {
     return b.toString();
   }
 
+  /** A program that omits {@link TrimFieldsProgram}. */
+  private static Program getProgram() {

Review Comment:
   The standard program is initialized as follows:
   ```
       return sequence(subQuery(metadataProvider),
           new DecorrelateProgram(),
           new TrimFieldsProgram(),
           program1,
   
           // Second planner pass to do physical "tweaks". This the first time
           // that EnumerableCalcRel is introduced.
           calc(metadataProvider));
   ```
   Which includes the `TrimFieldsProgram()`, so I had to manually initialize 
one to avoid adding that program.
   What do you think? Do you suggest a better way to create the program without 
`TrimFieldsProgram()`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to